Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-41125-phone-num-cleanup #20559

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Jan 31, 2025

Summary

  • Changes the phoneNumber regex for v2 2122/2122a for veteran and claimant.
  • Adjusts the dev swagger file accordingly.

Related issue(s)

Testing done

  • New code is covered by unit tests

Screenshots

What areas of the site does it impact?

modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified:   modules/claims_api/config/schemas/v2/2122.json
modified:   modules/claims_api/config/schemas/v2/2122a.json

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

…ant. Adjusts the dev swagger file accordingly.
@stiehlrod stiehlrod marked this pull request as ready for review January 31, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants