97999: Remove old DR controllers

[dfong-adh]

Summary

This removes unused DR controllers as traffic is directed to new endpoints (prefixed with decision_reviews) in the DR engine.

Removes the following endpoints:
v2/higher_level_reviews
v1/higher_level_reviews/contestable_issues
v1/notice_of_disagreements
v1/notice_of_disagreements/contestable_issues
v1/supplemental_claims
v1/supplemental_claims/contestable_issues

This is owned by Benefits Decision Review.

• This work is behind a feature toggle (flipper): YES/NO
  No

Related issue(s)

department-of-veterans-affairs/va.gov-team#97999
department-of-veterans-affairs/va.gov-team#102316

Testing done

Locally tested

• New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: app/controllers/v1/higher_level_reviews

[github-actions]

1 Error

🚫

This PR changes 1383 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files .github/CODEOWNERS (+0/-15) app/controllers/v1/decision_review_evidences_controller.rb (+0/-71) app/controllers/v1/higher_level_reviews/contestable_issues_controller.rb (+0/-41) app/controllers/v1/notice_of_disagreements/contestable_issues_controller.rb (+0/-17) app/controllers/v1/notice_of_disagreements_controller.rb (+0/-43) app/controllers/v1/supplemental_claims/contestable_issues_controller.rb (+0/-37) app/controllers/v1/supplemental_claims_controller.rb (+0/-122) app/controllers/v2/higher_level_reviews_controller.rb (+0/-52) spec/controllers/v1/decision_review_evidences_controller_spec.rb (+0/-188) spec/requests/swagger_spec.rb (+0/-26) spec/requests/v1/higher_level_reviews/contestable_issues_spec.rb (+0/-87) spec/requests/v1/notice_of_disagreements/contestable_issues_spec.rb (+0/-40) spec/requests/v1/notice_of_disagreements_spec.rb (+0/-155) spec/requests/v1/supplemental_claims/contestable_issues_spec.rb (+0/-74) spec/requests/v1/supplemental_claims_spec.rb (+0/-278) spec/requests/v2/higher_level_reviews_spec.rb (+0/-137) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: app/controllers/v1/higher_level_reviews