Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99555 add specs #20563

Merged
merged 6 commits into from
Feb 3, 2025
Merged

99555 add specs #20563

merged 6 commits into from
Feb 3, 2025

Conversation

balexandr
Copy link
Contributor

@balexandr balexandr commented Jan 31, 2025

ALL module code covered by unit tests.
Add a group in spec/spec_helper.rb for 'Burials'

Summary

  • Create tests for files in the new Burial module
  • Delete conflicting modules/classes outside of module
  • Port over existing tests into module
  • Add Burials to spec_helper to appear in coverage as its own category

Related issue(s)

Testing done

  • 100% text coverage

Screenshots

Screenshot 2025-01-31 at 6 08 34 PM

What areas of the site does it impact?

Burial module

Copy link

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: lib/burials

Copy link

github-actions bot commented Jan 31, 2025

1 Warning
⚠️ This PR changes 401 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+0/-2)

  • lib/burials/monitor.rb (+0/-119)

  • lib/burials/notification_callback.rb (+0/-10)

  • lib/burials/notification_email.rb (+0/-33)

  • {spec => modules/burials/spec}/lib/burials/notification_email_spec.rb (+4/-8)

  • spec/lib/burials/monitor_spec.rb (+0/-223)

  • spec/spec_helper.rb (+2/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to 99555-add-specs/main/main January 31, 2025 22:58 Inactive
Copy link

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: lib/burials

@va-vfs-bot va-vfs-bot temporarily deployed to 99555-add-specs/main/main January 31, 2025 23:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 99555-add-specs/main/main January 31, 2025 23:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 99555-add-specs/main/main February 1, 2025 00:58 Inactive
@balexandr balexandr marked this pull request as ready for review February 3, 2025 17:18
@balexandr balexandr requested review from a team as code owners February 3, 2025 17:18
Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balexandr balexandr merged commit 46c14bc into master Feb 3, 2025
38 of 39 checks passed
@balexandr balexandr deleted the 99555-add-specs branch February 3, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants