[ARP - lower camel responses - 1] set_key_transform :camel_lower

[nihil2501]

This is the head of a PR stack that switches all existing ARP endpoints to input and output camel cased request and response payloads explicitly and in particular bypasses olive_branch middleware. The PRs sequence the work like 1 <- 2 <- 3 <- 4 <- 5 and can each be approved one at a time in that order. Then that whole chain can get merged into this head PR and platform can re-approve a final time to go into master.

⚠️ Please feel free to visit the 5 minimal diffs in quick succession! ⚠️

The PR titles and minimal diffs are self explanatory:

• [ARP - lower camel responses - 1] set_key_transform :camel_lower #20621
• [ARP - lower camel responses - 2] camel case POA form persistence #20622
• [ARP - lower camel responses - 3] handle camel params in ARP IPF controller #20623
• [ARP - lower camel responses - 4] camel response in ARP users controller #20624
• [ARP - lower camel responses - 5] bypass olive branch #20625

It is worth reiterating the code comment that exists in the final PR of the PR stack that bypasses olive_branch for ARP endpoints:

olive_branch transforms (a) request and (b) response payloads.

(a) It deeply transforms request and query param keys.
At times it is convenient for params to act as snake-cased setters at a Ruby interface, but not always. Form resources are a possible example where not.

For now, let's wait to encounter the cases where we really want this convenience. If we do encounter some, we may discover that we want a more explicit and collocated way to opt in.

(b) It reloads the response from JSON, deeply transforms keys, and dumps back to JSON.
This is superfluous because our serialization layer jsonapi-serializer already has a configuration option for key casing. This realizes our desired casing the one and only time it is visiting an object during serialization.

[pixiitech]

looks good

The base branch was changed.

[github-actions]

1 Warning

⚠️

This PR changes 413 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/in_progress_forms_controller.rb (+1/-1) modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/representative_users_controller.rb (+7/-7) modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb (+38/-38) modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb (+1/-0) modules/accredited_representative_portal/config/initializers/bypass_olive_branch.rb (+17/-0) modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb (+42/-42) modules/accredited_representative_portal/spec/factories/representative_user.rb (+5/-1) modules/accredited_representative_portal/spec/requests/accredited_representative_portal/bypass_olive_branch_spec.rb (+38/-0) modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/in_progress_forms_spec.rb (+11/-14) modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb (+52/-59) modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/user_spec.rb (+8/-15) modules/accredited_representative_portal/spec/serializers/accredited_representative_portal/power_of_attorney_request_serializer_spec.rb (+8/-8) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger