CODEOWNERS alphabetization #20640
Merged
CODEOWNERS alphabetization #20640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmtolmach
commented
Feb 5, 2025
| @@ -459,7 +459,6 @@ app/services/form1010cg/service.rb @department-of-veterans-affairs/vfs-10-10 @de | |||
| app/services/form1010_ezr_attachments/file_type_validator.rb @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group | |||
| app/services/hca/overrides_parser.rb @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group | |||
| app/services/identity @department-of-veterans-affairs/octo-identity | |||
| app/services/identity/account_creator.rb @department-of-veterans-affairs/octo-identity | |||
There was a problem hiding this comment.
This is the only line I actually deleted. This line is covered by the line above it, so it's not needed.
All other "deletions" are actually moves.
shaunburdick
previously approved these changes
Feb 6, 2025
4 tasks
rmtolmach
changed the title
|
Ignore that comments above 😄 those were from when I was testing a CI change. I moved those changes into #20651. This PR is only for codeowners now. |
shaunburdick
approved these changes
Feb 6, 2025
LindseySaari
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-alphabetizing some CODEOWNER entries that I saw were out of place.
Related issue(s)
None. I'm on support this sprint and noticed this.
Testing done
What areas of the site does it impact?
codeowners