Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ndeb/102521 offramp log fix #20645

Merged
merged 67 commits into from
Feb 7, 2025
Merged

Ndeb/102521 offramp log fix #20645

merged 67 commits into from
Feb 7, 2025

Conversation

micahaspyr
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • *This work is behind a feature toggle (flipper): NO
  • Added in Rails logging for Datadog to report claims for manual reviews
  • Rails logs are needed here so that we can generate reports about which submissions are being processed manually
  • Ndbex Treella

Related issue(s)

Testing done

  • New code is covered by unit tests
  • No logging was being generated for manual review of 674 and 686 submissions
  • Checking if the logs are in datadog

What areas of the site does it impact?

Acceptance criteria

  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)

@va-vfs-bot va-vfs-bot temporarily deployed to ndeb/102521-offramp-log-fix/main/main February 6, 2025 06:56 Inactive
@evansmith evansmith marked this pull request as ready for review February 6, 2025 16:28
@evansmith evansmith requested review from a team as code owners February 6, 2025 16:28
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@micahaspyr micahaspyr merged commit 7a08d56 into master Feb 7, 2025
40 checks passed
@micahaspyr micahaspyr deleted the ndeb/102521-offramp-log-fix branch February 7, 2025 20:31
bramleyjl pushed a commit that referenced this pull request Feb 10, 2025
* level set

* level set with master

* removing yarn.lock

* FD

* pulling in main

* Levelset

* Added in proper logging

---------

Co-authored-by: micahaspyr <[email protected]>
freeheeling pushed a commit that referenced this pull request Feb 10, 2025
* level set

* level set with master

* removing yarn.lock

* FD

* pulling in main

* Levelset

* Added in proper logging

---------

Co-authored-by: micahaspyr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants