Burial 99564: Remove non module code and flipper logic #21086
+5
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
99564-remove-old-burial-logic/main/main
va-vfs-bot
temporarily deployed
to
99564-remove-old-burial-logic/main/main
This comment was marked as off-topic.
This comment was marked as off-topic.
va-vfs-bot
temporarily deployed
to
99564-remove-old-burial-logic/main/main
va-vfs-bot
temporarily deployed
to
99564-remove-old-burial-logic/main/main
balexandr
commented
Mar 5, 2025
wayne-weibel
changed the title
wayne-weibel
requested changes
Mar 5, 2025
Comment on lines
-185
to
-186
| '21P-527EZ' => 'Pensions', | ||
| '21P-530EZ' => 'Burials' |
There was a problem hiding this comment.
I was looking at this yesterday, and trying to determine exactly how/what it was used for - should this be removed? Can also be done for pensions?
Looks like there is some work to still be done for the prefill/profile to separate it from this shared monolith.
There was a problem hiding this comment.
@wayne-weibel We haven't enabled the Pension form profile on production yet. We can do that today and then we can wait a day or two and then remove it from here.
There was a problem hiding this comment.
i will enable that now and look to remove this piece in a future ticket
wayne-weibel
approved these changes
Mar 5, 2025
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
and removed
test-failure
labels
wayne-weibel
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove module level logic since we've fully cutover.
Summary
Related issue(s)
Testing done