Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missing form status job to inspect batches rather than individual records - IVC CHAMPVA #21092

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

michaelclement
Copy link
Contributor

@michaelclement michaelclement commented Mar 4, 2025

Summary

This PR updates the IVC CHAMPVA missingFormStatusJob periodic job so that in the event of failure emails needing to be sent to users, users only get a single email for a multi-file submission rather than an individual email for each file in the submission.

  • This work is behind a feature toggle (flipper): NO
  • Changes:
    • Added new helper function to retrieve forms by missing pega_status and group them into batches by UUID
  • This was done so that inspection is performed at the batch level rather than inspecting all constituent files that make up a form submission.
  • Team: IVC CHAMPVA

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Prior to this change we queried for individual form records that had a pega_status of nil. Then we would send an email for each of those records, even if they were part of a larger form submission.
  • To verify this new behavior, new unit tests were added to ensure new functionality was covered. Additionally, this was tested in the staging environment where emails were confirmed to be sent as expected.

Screenshots

NA

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@va-vfs-bot va-vfs-bot temporarily deployed to fix-missing-form-status-job-email-freq/main/main March 4, 2025 23:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to fix-missing-form-status-job-email-freq/main/main March 5, 2025 18:25 Inactive
@michaelclement michaelclement changed the title first pass at implementation Update missing form status job to inspect batches rather than individual records - IVC CHAMPVA Mar 5, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to fix-missing-form-status-job-email-freq/main/main March 5, 2025 19:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to fix-missing-form-status-job-email-freq/main/main March 5, 2025 19:26 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to fix-missing-form-status-job-email-freq/main/main March 5, 2025 19:45 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to fix-missing-form-status-job-email-freq/main/main March 5, 2025 21:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants