Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-61855 Added MHV API Gateway config settings #21097

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmoyer-va
Copy link
Contributor

@mmoyer-va mmoyer-va commented Mar 5, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Related issue(s)

MHV-61855 - Implement/configure updated tokens in lower environment (endpoint changes)

  • Configure this token in a lower environment, which will include adding a token as a secret in AWS.
  • Document all the steps

Feature Flag Y/N ?

DataDog Analytics Y/N ?

Manual Testing Y/N ?

Automated Testing Y/N ?

Accessibility Testing Y/N ?

UCD Validation Y/N

Acceptance Criteria:

AC1 Configuration is complete

AC2 Steps are documented

Testing done

  • This step is just adding configuration. The new endpoints have been tested, but pulling environment variables will have to be tested in a review instance or staging as we transition our endpoints to the new Gateway.

Screenshots

The AWS Params

image image

What areas of the site does it impact?

  • Just new config for now, but will eventually be used by all MHV on VA.gov applications

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mmoyer-va mmoyer-va marked this pull request as ready for review March 5, 2025 18:25
@mmoyer-va mmoyer-va requested review from a team as code owners March 5, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants