[ARP] Disable non-POA request routes outside development and test #21102
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Carry out this by-environment guard of these endpoints by using Flipper feature toggling and controller before actions instead.
ojbucao
approved these changes
Mar 5, 2025
chumpy
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these endpoints are still under development, they should be inaccessible in production. For now, this check is extra stringent, and makes these endpoints inaccessible anywhere outside development and test. But once development on these features picks back up, we want them to be accessible in staging too.
TODO: Carry out this per-environment guard of these endpoints by using Flipper feature toggling and controller before actions instead.