API-45450-bug-fix-request-index #21103
Open
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When the page size param is 1 BGS returns and object not an array. This updates to always return an array from that call modified: modules/claims_api/app/services/claims_api/power_of_attorney_request_service/index.rb new file: modules/claims_api/spec/services/power_of_attorney_request_service/index_spec.rb
va-vfs-bot
temporarily deployed
to
API-45450-bug-fix-request-index/main/main
cilestin
requested changes
Mar 5, 2025
| it 'does not return an error when page_size is 1' do | ||
| expect do | ||
| subject.get_poa_list | ||
| end.not_to raise_error(TypeError) |
There was a problem hiding this comment.
Let's remove the specific type check (in both places). We don't care what kind of error was being thrown, we need to ensure sure it doesn't throw errors at all; doing so means that this won't blindly go green if some edit in the future throws a NoMethodError or the like.
There was a problem hiding this comment.
Will do,
bb6c77e
|
|
||
| context 'when page size is over 1 and less then the max allowed' do | ||
| before do | ||
| @page_size = 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.pluckto get the procID was breaking. This fix is designed to mae sure that value coming back is always an arrayRelated issue(s)
API-45450
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?