Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100025 Travel Pay, SMOC submission confirmation content #34116

Merged
merged 16 commits into from
Jan 31, 2025

Conversation

seesleestak
Copy link
Contributor

@seesleestak seesleestak commented Jan 15, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)

    Add content for SMOC submission confirmation page

  • (Which team do you work for, does your team own the maintenance of this component?)

    Travel Pay

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

    Phased rollout beginning Feb 2025

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
    Before the changes the page was only a stub with a title
  • Describe the steps required to verify your changes are working as expected
    I added a short circuit in the SubmitFlowWrapper to get the confirmation page showing without necessary logic
  useEffect(() => {
    setPageIndex(5);
  }, []);
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile before-mobile after-mobile
Desktop before-desktop after-desktop

What areas of the site does it impact?

Travel Pay only

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@seesleestak seesleestak changed the title Travel Pay, SMOC submission confirmation content 100025 Travel Pay, SMOC submission confirmation content Jan 15, 2025
@seesleestak
Copy link
Contributor Author

Like #34032, these are changes applied from #33664 in order to break it down into smaller chunks.

@va-vfs-bot va-vfs-bot temporarily deployed to master/cc/smoc-confirmation-content/main January 16, 2025 16:08 Inactive
liztownd
liztownd previously approved these changes Jan 21, 2025
Copy link
Contributor

@liztownd liztownd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small comments, but overall LGTM. 🎉

@va-vfs-bot va-vfs-bot temporarily deployed to master/cc/smoc-confirmation-content/main January 27, 2025 14:23 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/cc/smoc-confirmation-content/main January 27, 2025 15:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/cc/smoc-confirmation-content/main January 27, 2025 19:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/cc/smoc-confirmation-content/main January 27, 2025 20:28 Inactive
Copy link
Contributor

@kjduensing kjduensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚂

@seesleestak seesleestak marked this pull request as ready for review January 28, 2025 14:40
@seesleestak seesleestak requested a review from a team as a code owner January 28, 2025 14:40
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seesleestak seesleestak merged commit 324fb3f into main Jan 31, 2025
79 checks passed
@seesleestak seesleestak deleted the cc/smoc-confirmation-content branch January 31, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants