-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
100025 Travel Pay, SMOC submission confirmation content #34116
Conversation
…-website into cc/smoc-confirmation-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple small comments, but overall LGTM. 🎉
src/applications/travel-pay/components/submit-flow/pages/ConfirmationPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/travel-pay/components/submit-flow/pages/ConfirmationPage.jsx
Outdated
Show resolved
Hide resolved
…-website into cc/smoc-confirmation-content
src/applications/travel-pay/tests/components/submit-flow/pages/ConfirmationPage.unit.spec.jsx
Outdated
Show resolved
Hide resolved
src/applications/travel-pay/components/submit-flow/pages/ConfirmationPage.jsx
Outdated
Show resolved
Hide resolved
src/applications/travel-pay/components/submit-flow/pages/ConfirmationPage.jsx
Outdated
Show resolved
Hide resolved
…-website into cc/smoc-confirmation-content
…-website into cc/smoc-confirmation-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
(Summarize the changes that have been made to the platform)
Add content for SMOC submission confirmation page
(Which team do you work for, does your team own the maintenance of this component?)
Travel Pay
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
Phased rollout beginning Feb 2025
Related issue(s)
Add content to Confirmation Page [SMOC flow FE] va.gov-team#100025
INITIATIVE: Simple Mileage-Only Claims va.gov-team#83829
Testing done
Before the changes the page was only a stub with a title
I added a short circuit in the
SubmitFlowWrapper
to get the confirmation page showing without necessary logicScreenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Travel Pay only
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication