-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full form data to array builder #34155
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for adding this
@@ -349,6 +349,7 @@ class FormPage extends React.Component { | |||
name={route.pageConfig.pageKey} | |||
title={route.pageConfig.title} | |||
data={data} | |||
fullData={form.data} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also get this data by using getFormData passed into CustomPage. Could just use that, or if still want to introduce this on its own, that seems OK too.
@@ -463,7 +469,7 @@ export function updateUiSchema(schema, uiSchema, formData) { | |||
return currentUiSchema; | |||
} | |||
|
|||
const newProps = uiSchemaUpdater(formData); | |||
const newProps = uiSchemaUpdater(formData, fullData || formData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of also giving this an index? the user would probably have to use window.location.pathname parsing to check if the index is the same, (since our data structure isn't multiple indecies for uiSchema), but maybe useful.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
department-of-veterans-affairs/va.gov-team#96602
Testing done
Screenshots
N/A
What areas of the site does it impact?
Platform array builder functions
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?