Skip to content

fix(windows): use JAVA_HOME when java is not on PATH #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhumblot merged 2 commits into from
Jul 23, 2026
+4 −1
Merged

fix(windows): use JAVA_HOME when java is not on PATH #8656

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508ca0c
Fix Windows CLI to use JAVA_HOME when java is not on PATH
Jul 12, 2026
bf029e3
fix: simplify JAVA_HOME fallback logic for pull request finding
mohan485 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cli/src/main/conf/windowsBinTemplate.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ for %%i in ("%~dp0..") do set "BASEDIR=%%~fi"
set REPO=
#ENV_SETUP#

if "%JAVACMD%"=="" set JAVACMD=#JAVA_BINARY#
if "%JAVACMD%"=="" (
if exist "%JAVA_HOME%\bin\java.exe" (
set "JAVACMD=%JAVA_HOME%\bin\java.exe"
) else (
set "JAVACMD=#JAVA_BINARY#"
)
)
Comment thread
mohan485 marked this conversation as resolved.

if "%REPO%"=="" set REPO=%BASEDIR%\#REPO#

Expand Down
Loading