fix: missionRecord -> mission startedAt으로 변경하여 sinceDay 계산 수정 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdomo
approved these changes
Jan 22, 2024
Comment on lines
87
to
90
| long sinceDay = | ||
| Duration.between(missionRecord.getMission().getStartedAt(), LocalDateTime.now()) | ||
| .toDays() | ||
| + 1; |
There was a problem hiding this comment.
상단에 매직넘버 상수로 빼는게 좋을 것 같아용
private static final int DAYS_ADJUSTMENT = 1;
Suggested change
| long sinceDay = | |
| Duration.between(missionRecord.getMission().getStartedAt(), LocalDateTime.now()) | |
| .toDays() | |
| + 1; | |
| long sinceDay = | |
| Duration.between(missionRecord.getMission().getStartedAt(), LocalDateTime.now()) | |
| .toDays() + DAYS_ADJUSTMENT; |
또는
Suggested change
| long sinceDay = | |
| Duration.between(missionRecord.getMission().getStartedAt(), LocalDateTime.now()) | |
| .toDays() | |
| + 1; | |
| long sinceDay = | |
| Duration.between(missionRecord.getMission().getStartedAt(), LocalDateTime.now().minusDays(DAYS_ADJUSTMENT)) | |
| .toDays(); |
와 같이 처리할수도 있을 것 같네용
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
sinceDay값이 항상 0일차로 나오는 문제 #201📌 작업 내용 및 특이사항
📝 참고사항
📚 기타