Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 소셜 로그인 시 카카오 앱 환경인 경우 nonce 검증을 하지 않도록 변경 #205

Merged
merged 8 commits into from
Jan 23, 2024
Merged

fix: 소셜 로그인 시 카카오 앱 환경인 경우 nonce 검증을 하지 않도록 변경 #205

merged 8 commits into from
Jan 23, 2024

Conversation

uwoobeat
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 프로퍼티 및 토큰 검증 로직 리팩토링
    • 노출되면 안되는 aud 값만 시크릿 처리하고 나머지는 enum 상수의 필드로 넣었습니다.
    • ConfigurationProperties 매핑해올 때 Map으로 가져오고 OauthProvider를 키로 가지도록 리팩토링했습니다.
    • 카카오 앱 환경인 경우 nonce 검증을 스킵하도록 변경했습니다.

📝 참고사항

📚 기타

@uwoobeat uwoobeat requested review from kdomo and char-yb January 23, 2024 07:45
@uwoobeat uwoobeat self-assigned this Jan 23, 2024
kdomo
kdomo approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴니당 구두로 이야기했던 닉네임쪽 로직만 추가해주세용

char-yb
char-yb approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

40 New issues
0 Security Hotspots
48.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@uwoobeat uwoobeat merged commit cc811ff into develop Jan 23, 2024
2 checks passed
@uwoobeat uwoobeat deleted the fix/204-kakao-native-nonce branch January 23, 2024 15:09
@github-actions github-actions bot added the merged 머지된 PR label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdomo kdomo kdomo approved these changes

@char-yb char-yb char-yb approved these changes

Assignees

@uwoobeat uwoobeat

Labels
merged 머지된 PR
Projects
10mm-server
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 소셜 로그인 시 카카오 앱 환경인 경우 nonce 검증을 하지 않도록 변경
3 participants
@uwoobeat @kdomo @char-yb