Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request 시 QueryString 아닌 pathVariable targetId로 변경 #211

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: request 시 QueryString 아닌 pathVariable targetId로 변경 #211

merged 2 commits into from
Jan 23, 2024

Conversation

char-yb
Copy link
Member

@char-yb char-yb commented Jan 23, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

📝 참고사항

📚 기타

@char-yb char-yb added 🥇 P1 급하고 꼭 필요한 이슈 🐛 bug/error 버그 및 에러 픽스 ♻️ refactor 기능 개선 labels Jan 23, 2024
@char-yb char-yb added this to the 2.5차 스프린트 milestone Jan 23, 2024
@char-yb char-yb requested a review from kdomo January 23, 2024 15:39
@char-yb char-yb self-assigned this Jan 23, 2024
@char-yb char-yb linked an issue Jan 23, 2024 that may be closed by this pull request
🐛 친구 미션 request 시 QueryString(nickname)이 아닌 PathVariable(targetId - memberId)로 변경 #210
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

40 New issues
0 Security Hotspots
48.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@char-yb char-yb changed the title fix: request 시 QueryString 아닌 pathVariable memberId로 변경 fix: request 시 QueryString 아닌 pathVariable targetId로 변경 Jan 23, 2024
@char-yb char-yb merged commit a58e109 into develop Jan 23, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdomo kdomo kdomo approved these changes

Assignees

@char-yb char-yb

Labels
🐛 bug/error 버그 및 에러 픽스 merged 머지된 PR 🥇 P1 급하고 꼭 필요한 이슈 ♻️ refactor 기능 개선
Projects
10mm-server
Status: 완료
Milestone
2.5차 스프린트
Development

Successfully merging this pull request may close these issues.

🐛 친구 미션 request 시 QueryString(nickname)이 아닌 PathVariable(targetId - memberId)로 변경
2 participants
@char-yb @kdomo