feat: 소셜 로그인 시 임시 회원가입 할 때 랜덤 생성 닉네임 넣어주는 기능 구현 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
char-yb
approved these changes
Jan 24, 2024
Comment on lines
+21
to
+23
|
|
||
| return prefix + animalName; | ||
| } |
There was a problem hiding this comment.
혹시 prefix + " " + animalName 이렇게 가능할까용?
형용사 띄어쓰기 동물이름이 좋아보여서용
There was a problem hiding this comment.
음 닉네임에는 공백 없는게 좋다고 생각해서요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
fetchOrCreate두 번 호출하는 부분 있어서 제거 및 개선📝 참고사항
📚 기타