Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 내가 팔로우 한 사용자들 닉네임,프로필 조회 #215

Merged
merged 5 commits into from
Jan 24, 2024
Merged

feat: 내가 팔로우 한 사용자들 닉네임,프로필 조회 #215

merged 5 commits into from
Jan 24, 2024

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Jan 24, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

|image

  • 로그인 된 회원 기준 팔로우 한 사람들을 조회
  • 이 때, 정렬 조건은 팔로우 목록 중 최신에 미션을 완료한 사람이 있다면 미션 완료한 시간이 최근인 사람 먼저
  • 미션을 완료한 사람이 없다면 디폴트 정렬조건으로 팔로우를 한 시간 최신순으로 정렬

@kdomo kdomo added ✨ feature 새로운 기능 추가 및 수정 ✅ test 테스트 작업 labels Jan 24, 2024
@kdomo kdomo added this to the 2.5차 스프린트 milestone Jan 24, 2024
@kdomo kdomo requested review from char-yb and uwoobeat January 24, 2024 12:26
@kdomo kdomo self-assigned this Jan 24, 2024
uwoobeat
uwoobeat approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 고생하셨어요
로직 정확하게 이해 완료했습니다

src/main/java/com/depromeet/domain/follow/application/FollowService.java Outdated
@@ -79,6 +87,71 @@ public FollowFindMeInfoResponse findMeFollowInfo() {
return FollowFindMeInfoResponse.of(followingCount, followerCount);
}

@Transactional(readOnly = true) // TODO: 로직 개선 필요
public List<FollowedMemberResponse> findAllFollowedMember() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리소스가 앞에 가야 하므로 MemberFollowedResponse가 적절할 것 같습니다

@kdomo kdomo force-pushed the feature/198-follow-members-info branch from 57e4ccd to 558c81d Compare January 24, 2024 14:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

46 New issues
0 Security Hotspots
51.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kdomo kdomo merged commit dde73c3 into develop Jan 24, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uwoobeat uwoobeat uwoobeat approved these changes

@char-yb char-yb Awaiting requested review from char-yb char-yb is a code owner

Assignees

@kdomo kdomo

Labels
✨ feature 새로운 기능 추가 및 수정 merged 머지된 PR ✅ test 테스트 작업
Projects
10mm-server
Status: 완료
Milestone
2.5차 스프린트
Development

Successfully merging this pull request may close these issues.

✨ 내가 팔로우 한 사용자들 닉네임,프로필 조회
2 participants
@kdomo @uwoobeat