Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Build시 appleboy/[email protected] 속도 개선 #216

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Jan 24, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

image

  • 현재 Build시에 appleboy/[email protected]를 사용하여 docker-compose.yml을 항시 복사하고 있습니다.
  • 해당 step은 docker-compose.yml의 변경과 없이 항상 실행되며 약 30s가 걸린다.
  • 파일이 업데이트 되었는지 확인이 가능한 burnett01/rsync-deployments 사용

burnett01/rsync-deployments의 switches 옵션

-a: archive
-v: verbose
-z: compress
-r: recursive
--delete: delete files that are not in the source directory

📝 참고사항

Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
근데 scp-action이 오래 걸리는 원인이 뭐였나요?

@kdomo
Copy link
Member Author

kdomo commented Jan 24, 2024

lgtm 근데 scp-action이 오래 걸리는 원인이 뭐였나요?

scp-action의 동작은 해당 파일(docker-compose.yml)이 변경되지 않아도 항상 복사를 진행하기 때문에
오래 걸린걸로 예상되어용

변경된 action은 rsync로 remote-update 프로토콜을 이용해서 첫 동작에서만 파일을 복사하고, 그 이후부터는 다른 부분만 복사하기 때문에 빠르고 효율적입니당.

@kdomo kdomo force-pushed the refactor/200-build-speed-improvement branch from b131d1d to b53421c Compare January 24, 2024 15:26
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

46 New issues
0 Security Hotspots
51.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kdomo kdomo merged commit 8224090 into develop Jan 24, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 머지된 PR ♻️ refactor 기능 개선
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

♻️ Build시 appleboy/[email protected] 속도 개선
3 participants