feat: 소셜 로그인 정보 조회하기 기능 구현 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kdomo
approved these changes
Jan 24, 2024
Comment on lines
+44
to
+53
| private void saveAndRegisterMember(OauthInfo oauthInfo) { | ||
| Member member = Member.createGuestMember(oauthInfo, "testNickname"); | ||
| memberRepository.save(member); | ||
| member.register("testNickname"); | ||
| PrincipalDetails principalDetails = new PrincipalDetails(1L, "USER"); | ||
| Authentication authentication = | ||
| new UsernamePasswordAuthenticationToken( | ||
| principalDetails, null, principalDetails.getAuthorities()); | ||
| SecurityContextHolder.getContext().setAuthentication(authentication); | ||
| } |
Comment on lines
+22
to
+26
| return Arrays.stream(values()) | ||
| .filter(oauthProvider -> oauthProvider.issuer.equals(issuer)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new CustomException(ErrorCode.OAUTH_PROVIDER_NOT_FOUND)); | ||
| } |
Comment on lines
+62
to
+66
| private void validateSocialInfoNotNull(Member member) { | ||
| if (member.getOauthInfo() == null) { | ||
| throw new CustomException(ErrorCode.MEMBER_SOCIAL_INFO_NOT_FOUND); | ||
| } | ||
| } |
애플 이메일 id token으로 넘어오는거 체크했습니다 감사용 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
oidcUser에서getEmail()만 해주면 됨"provider": "KAKAO")of로 순회하면서 issuer로 프로바이더 enum을 결정함📝 참고사항
📚 기타