Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 통계 현황에서 총 미션 달성률 항상 100% 나오는 문제 #221

Merged
merged 5 commits into from
Jan 24, 2024
Merged

fix: 통계 현황에서 총 미션 달성률 항상 100% 나오는 문제 #221

merged 5 commits into from
Jan 24, 2024

Conversation

char-yb
Copy link
Member

@char-yb char-yb commented Jan 24, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

📝 참고사항

  • Test 코드는 다른 Feature 개발 일정이 끝나는대로 추가하겠습니다... PostMan으로는 테스트 완료했습니도

📚 기타

@char-yb char-yb added 🥇 P1 급하고 꼭 필요한 이슈 🐛 bug/error 버그 및 에러 픽스 labels Jan 24, 2024
@char-yb char-yb added this to the 2.5차 스프린트 milestone Jan 24, 2024
@char-yb char-yb requested a review from kdomo January 24, 2024 15:23
@char-yb char-yb self-assigned this Jan 24, 2024
@char-yb char-yb linked an issue Jan 24, 2024 that may be closed by this pull request
🐛 통계 총 미션 달성률이 항상 100%로 나오는 문제 #214
Closed
kdomo
kdomo requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 고생하셨습니다

계산 식이 들어가서 요 부분 테스트 코드만 추가해주시면 감사하겠습니당

kdomo
kdomo approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 위에 적어놓은걸 못봤군요
테스트코드 제가 추가해둘게용

@char-yb
Copy link
Member Author

char-yb commented Jan 24, 2024

아 위에 적어놓은걸 못봤군요 테스트코드 제가 추가해둘게용

감사합니도..!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

47 New issues
0 Security Hotspots
51.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@char-yb char-yb merged commit 9fe0561 into develop Jan 24, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdomo kdomo kdomo approved these changes

Assignees

@char-yb char-yb

Labels
🐛 bug/error 버그 및 에러 픽스 merged 머지된 PR 🥇 P1 급하고 꼭 필요한 이슈
Projects
10mm-server
Status: 완료
Milestone
2.5차 스프린트
Development

Successfully merging this pull request may close these issues.

🐛 통계 총 미션 달성률이 항상 100%로 나오는 문제
2 participants
@char-yb @kdomo