Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 닉네임 검색 기능 #225

Merged
merged 3 commits into from
Jan 25, 2024
Merged

feat: 닉네임 검색 기능 #225

merged 3 commits into from
Jan 25, 2024

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Jan 25, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 닉네임으로 유저 검색하는 기능을 추가합니다
  • 닉네임 검색 시 해당 유저의 프로필 이미지, 닉네임, 팔로우 상태를 응답합니다.
  • 검색 정렬조건에 키워드가 일치하는경우 최상단이고 그 이후로는 사전순 입니다.
  • 비지니스 로직 테스트코드 작성해놓았으니 참고 부탁드립니당

📚 기타

  • 검색 특이 케이스 자음에 받침이 들어간 경우는 형태소 분석이 필요하다고 판단하였고 리소스를 고려하여 우선순위 낮다고 판단

@kdomo kdomo added ✨ feature 새로운 기능 추가 및 수정 ✅ test 테스트 작업 labels Jan 25, 2024
@kdomo kdomo added this to the 2.5차 스프린트 milestone Jan 25, 2024
@kdomo kdomo requested a review from char-yb January 25, 2024 09:09
@kdomo kdomo self-assigned this Jan 25, 2024
@kdomo kdomo force-pushed the feature/217-nickname-search branch from df622f0 to 0627cbb Compare January 25, 2024 09:17
@kdomo kdomo requested a review from uwoobeat January 25, 2024 09:17
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

49 New issues
0 Security Hotspots
53.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 달았습니당

Comment on lines 20 to 25
Optional<Member> findByProfileNickname(String nickname);

@Query(
"SELECT m FROM Member m WHERE m.profile.nickname like %:searchNickname% AND m.profile.nickname != :myNickname")
List<Member> nicknameSearch(String searchNickname, String myNickname);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like도 Querydsl 되지 않나요??? Native로 작성하신 이유가 궁금해용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

복잡한 로직이 들어간게 아니여서 QueryDSL을 사용하지 않아도 된다고 판단했어용,
다만 Spring Data Jpa를 썼을때는 메소드 네이밍이 길어지기 때문에 Query어노테이션을 사용해서 처리했슴니다!

Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdomo kdomo merged commit ca3b8bc into develop Jan 25, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature 새로운 기능 추가 및 수정 merged 머지된 PR ✅ test 테스트 작업
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

✨ 닉네임 검색 기능
2 participants