refactor: Image 업로드 시 ImageKey 관리 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char-yb
reviewed
Jan 25, 2024
Comment on lines
22
to
26
| private Long targetId; | ||
|
|
||
| private String imageKey; | ||
|
|
There was a problem hiding this comment.
String이 아닌 char 배열을 사용하는게 낫다라는 뜻일까요?
아니면 컬럼의 length를 맞춰주는게 좋겠다 라는 뜻일까요?
Comment on lines
+11
to
+15
| @Query( | ||
| "select i from Image i where i.imageType = :imageType and i.targetId = :targetId and i.imageFileExtension = :imageFileExtension order by i.id desc limit 1") | ||
| Optional<Image> queryImageKey( | ||
| ImageType imageType, Long targetId, ImageFileExtension imageFileExtension); | ||
| } |
There was a problem hiding this comment.
가장 최근 row를 가져오는 이유는
최근 갱신된 imageKey를 가져오기 위함인가용?
There was a problem hiding this comment.
네 맞습니다 presignedUrl을 생성하고 이미지 업로드를 처리하지 않았을 경우 해당 key값은 사용되지 않아서,
가장 최신껄 가져오도록 해놨습니당
char-yb
approved these changes
Jan 25, 2024
kdomo
force-pushed
the
refactor/185-image-improvement
branch
from
1c5a6b5 to
09daed5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항