Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 이미지 확장자 테스트용 로그 출력문 제거 #242

Merged
merged 1 commit into from
Jan 28, 2024
Merged

refactor: 이미지 확장자 테스트용 로그 출력문 제거 #242

merged 1 commit into from
Jan 28, 2024

Conversation

uwoobeat
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 이미지 확장자 로그 찍는 부분 제거

📝 참고사항

📚 기타

@uwoobeat uwoobeat requested review from kdomo and char-yb January 28, 2024 15:40
@uwoobeat uwoobeat self-assigned this Jan 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

50 New issues
0 Security Hotspots
52.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kdomo
kdomo approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그 보니까 해당 부분만 찍히더라구용

로그 컨벤션 필요

@uwoobeat
Copy link
Member Author

로그 보니까 해당 부분만 찍히더라구용

로그 컨벤션 필요

지금 dev, prod에서 예외 터지면 trace 주르륵 다 찍혀서 이 부분도 수정해야 하는데 논의 ㄱㄱ하시죠

@uwoobeat uwoobeat merged commit 931ce7f into develop Jan 28, 2024
3 checks passed
@uwoobeat uwoobeat deleted the fix/241-delete-print branch January 28, 2024 16:38
@github-actions github-actions bot added the merged 머지된 PR label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdomo kdomo kdomo approved these changes

@char-yb char-yb Awaiting requested review from char-yb char-yb is a code owner

Assignees

@uwoobeat uwoobeat

Labels
merged 머지된 PR
Projects
10mm-server
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 이미지 확장자 테스트용 출력문이 남아있는 문제
2 participants
@uwoobeat @kdomo