Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 미션 내역 상세 N일차 표기 수정 #246

Closed
wants to merge 3 commits into from

Conversation

char-yb
Copy link
Member

@char-yb char-yb commented Jan 29, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

📝 참고사항

📚 기타

@char-yb char-yb added 🥇 P1 급하고 꼭 필요한 이슈 🐛 bug/error 버그 및 에러 픽스 labels Jan 29, 2024
@char-yb char-yb added this to the 2.5차 스프린트 milestone Jan 29, 2024
@char-yb char-yb self-assigned this Jan 29, 2024
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

68 New issues
0 Security Hotspots
52.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kdomo
Copy link
Member

kdomo commented Jan 29, 2024

요거 제가 헷갈려서 기획쪽이랑 이야기 해보고 리뷰 달게용!

@char-yb
Copy link
Member Author

char-yb commented Jan 29, 2024

넵 일단 채연님과 의논했을땐 저렇게 표기되는 방향으로 얘기했어서 확인 후 Reply 해주세용

@kdomo
Copy link
Member

kdomo commented Jan 29, 2024

미션 생성일 기준으로 잡아야한다고 이해했는데, 기존 코드가 의도대로 동작하는게 맞지 않나용??


+추가로 Duration.between 하게되었을 때 두 날짜의 차이 값을 return하여
합산 시간이 24시간을 넘어가게되면 day가 하루 증가하는 이슈도 있을 것 같아용

long sinceDay =
                Duration.between(missionRecord.getMission().getStartedAt().toLocalDate(), LocalDateTime.now().toLocalDate())
                                .toDays()
                        + DAYS_ADJUSTMENT;

따라서 위와같이 LocalDate끼리 비교해야 할 것 같습니다

@kdomo
Copy link
Member

kdomo commented Jan 29, 2024

@char-yb
Copy link
Member Author

char-yb commented Jan 30, 2024

확인해주셔서 감사해용 도모님👍

@char-yb char-yb closed this Jan 30, 2024
@github-actions github-actions bot added the merged 머지된 PR label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug/error 버그 및 에러 픽스 merged 머지된 PR 🥇 P1 급하고 꼭 필요한 이슈
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

🐛 미션 내역 상세 몇 일차인지 표기 수정
2 participants