fix: 미션 리스트 조회 시 InProgress인 미션만 조회로 변경 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdomo
requested changes
Jan 29, 2024
Comment on lines
82
to
84
| private BooleanExpression durationStatusNotInFinished() { | ||
| return mission.durationStatus.notIn(DurationStatus.FINISHED); | ||
| } |
There was a problem hiding this comment.
현재 FINISHED가 아닌것은 IN_PROGRESS로 보고있지만,
추 후 기획이 변경되거나 Enum값이 추가된다거나 했을 때
버그가 발생한다거나 해당 부분 찾기 어려울 꺼 같아서
IN_PROGRESS인 놈들만 in으로 거는게 더 좋아보여용!!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타