-
Notifications
You must be signed in to change notification settings - Fork 854
fix(color-contrast): do not incomplete on textarea #4968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The description here has no content. We should probably at least have what the patch is doing and how it addresses the problem at a minimum for content. That way as we merge the commit history starts to contain some useful information when going through the history and bisecting problems. |
Agreed. @straker please add a PR description here. All PRs need a description that tells the work that was done and anything that will help the reviewers. |
|
Drafting since Steve is out for a while on vacation. |
|
The description isn't needed if the issue it's closing details all the work, in this case #4947 (comment). |
|
A description is still needed. The point is once this is merged we take the PR title and description to make the commit body. Which is useful context to search in the repository history without needing to go elsewhere. When triaging things (particularly bisecting) having commit data that is meaningful to the changes is valuable. |
|
Also, the last comment in the issue is basically half of what we want in the PR description. The only extra thing the description needs is a minimal definition of what the original problem was. |
### [4.11.1](v4.11.0...v4.11.1) (2026-01-06) ### Bug Fixes - allow shadow roots in axe.run contexts ([#4952](#4952)) ([d4aee16](d4aee16)), closes [#4941](#4941) - color contrast fails for oklch and oklab with none ([#4959](#4959)) ([8f249fd](8f249fd)) - **color-contrast:** do not incomplete on textarea ([#4968](#4968)) ([d271788](d271788)), closes [#4947](#4947) - **commons/color:** Match browser behavior for out-of-gamut oklch colors ([#4908](#4908)) ([5036be8](5036be8)) - don't runs rules that select `html` on nested `html` elements ([#4969](#4969)) ([1e9a5c3](1e9a5c3)) - replaced luminance threshold constant 0.03928 with 0.04045 ([#4934](#4934)) ([316967d](316967d)), closes [#4933](#4933) - **rgaa:** adjust mapping of aria-hidden-\* and valid-lang ([#4935](#4935)) ([77571f2](77571f2)) - **valid-lang:** update valid-langs for newer language codes ([#4966](#4966)) ([c3f5446](c3f5446)), closes [#4963](#4963) This PR was opened by a robot 🤖 🎉
Closes: #4947