Skip to content

Conversation

@straker
Copy link
Contributor

@straker straker commented Dec 15, 2025

Closes: #4947

@straker straker requested a review from a team as a code owner December 15, 2025 22:54
@Garbee
Copy link
Member

Garbee commented Dec 18, 2025

The description here has no content. We should probably at least have what the patch is doing and how it addresses the problem at a minimum for content. That way as we merge the commit history starts to contain some useful information when going through the history and bisecting problems.

@davidg-dq
Copy link

The description here has no content. We should probably at least have what the patch is doing and how it addresses the problem at a minimum for content. That way as we merge the commit history starts to contain some useful information when going through the history and bisecting problems.

Agreed. @straker please add a PR description here. All PRs need a description that tells the work that was done and anything that will help the reviewers.

@Garbee
Copy link
Member

Garbee commented Dec 19, 2025

Drafting since Steve is out for a while on vacation.

@Garbee Garbee marked this pull request as draft December 19, 2025 14:38
@straker
Copy link
Contributor Author

straker commented Jan 5, 2026

The description isn't needed if the issue it's closing details all the work, in this case #4947 (comment).

@straker straker marked this pull request as ready for review January 5, 2026 16:46
@Garbee
Copy link
Member

Garbee commented Jan 5, 2026

A description is still needed. The point is once this is merged we take the PR title and description to make the commit body. Which is useful context to search in the repository history without needing to go elsewhere. When triaging things (particularly bisecting) having commit data that is meaningful to the changes is valuable.

@Garbee
Copy link
Member

Garbee commented Jan 5, 2026

Also, the last comment in the issue is basically half of what we want in the PR description. The only extra thing the description needs is a minimal definition of what the original problem was.

@straker straker merged commit d271788 into develop Jan 6, 2026
23 checks passed
@straker straker deleted the fix-contrast-textarea branch January 6, 2026 17:48
WilcoFiers added a commit that referenced this pull request Jan 6, 2026
###
[4.11.1](v4.11.0...v4.11.1)
(2026-01-06)

### Bug Fixes

- allow shadow roots in axe.run contexts
([#4952](#4952))
([d4aee16](d4aee16)),
closes [#4941](#4941)
- color contrast fails for oklch and oklab with none
([#4959](#4959))
([8f249fd](8f249fd))
- **color-contrast:** do not incomplete on textarea
([#4968](#4968))
([d271788](d271788)),
closes [#4947](#4947)
- **commons/color:** Match browser behavior for out-of-gamut oklch
colors ([#4908](#4908))
([5036be8](5036be8))
- don't runs rules that select `html` on nested `html` elements
([#4969](#4969))
([1e9a5c3](1e9a5c3))
- replaced luminance threshold constant 0.03928 with 0.04045
([#4934](#4934))
([316967d](316967d)),
closes [#4933](#4933)
- **rgaa:** adjust mapping of aria-hidden-\* and valid-lang
([#4935](#4935))
([77571f2](77571f2))
- **valid-lang:** update valid-langs for newer language codes
([#4966](#4966))
([c3f5446](c3f5446)),
closes [#4963](#4963)

This PR was opened by a robot 🤖 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contrast Error “Background Color Cannot Be Determined” on Textarea

6 participants