Skip to content

fix(checks): handle multiple aria-errormessage IDs #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JustasMonkev wants to merge 4 commits into
base: develop
Choose a base branch
from
+43 −1
Open

fix(checks): handle multiple aria-errormessage IDs #4973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bae1728
fix(checks): handle multiple ID tokens in aria-errormessage with aria…
JustasMonkev Dec 27, 2025
e24e223
fix(checks): pass aria-error message when any token is describedby
JustasMonkev Jan 7, 2026
112d4d2
Merge branch 'develop' into fix/aria-errormessage-multiple-idrefs-4957
JustasMonkev Jan 7, 2026
03139c9
Merge branch 'develop' into fix/aria-errormessage-multiple-idrefs-4957
JustasMonkev Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/checks/aria/aria-errormessage-evaluate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,13 @@ export default function ariaErrormessageEvaluate(node, options, virtualNode) {
});
return false;
}
const describedbyTokens = tokenList(virtualNode.attr('aria-describedby'));
const errormessageTokens = tokenList(attr);
return (
getExplicitRole(idref) === 'alert' ||
idref.getAttribute('aria-live') === 'assertive' ||
idref.getAttribute('aria-live') === 'polite' ||
tokenList(virtualNode.attr('aria-describedby')).indexOf(attr) > -1
errormessageTokens.some(token => describedbyTokens.includes(token))
);
}

Expand Down
40 changes: 40 additions & 0 deletions test/checks/aria/errormessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,46 @@ describe('aria-errormessage', function () {
);
});

it('should return true if aria-errormessage has multiple ids that are all in aria-describedby', function () {
var vNode = queryFixture(
'<input id="target" aria-invalid="true" aria-describedby="error1 error2" aria-errormessage="error1 error2">' +
'<div id="error1">Error 1</div>' +
'<div id="error2">Error 2</div>'
);
assert.isTrue(
axe.testUtils
.getCheckEvaluate('aria-errormessage')
.call(checkContext, null, null, vNode)
);
});

it('should return true if aria-errormessage has multiple ids but at least one is in aria-describedby', function () {
var vNode = queryFixture(
'<input id="target" aria-invalid="true" aria-describedby="error1" aria-errormessage="error1 error2">' +
'<div id="error1">Error 1</div>' +
'<div id="error2">Error 2</div>'
);
assert.isTrue(
axe.testUtils
.getCheckEvaluate('aria-errormessage')
.call(checkContext, null, null, vNode)
);
});

it('should return false if aria-errormessage has multiple ids but none are in aria-describedby', function () {
var vNode = queryFixture(
'<input id="target" aria-invalid="true" aria-describedby="other" aria-errormessage="error1 error2">' +
'<div id="other">Other</div>' +
'<div id="error1">Error 1</div>' +
'<div id="error2">Error 2</div>'
);
assert.isFalse(
axe.testUtils
.getCheckEvaluate('aria-errormessage')
.call(checkContext, null, null, vNode)
);
});

it('sets an array of IDs in data', function () {
var vNode = queryFixture(
'<div id="target" aria-errormessage=" foo bar \tbaz " aria-invalid="true">' +
Expand Down