Resources are rendered using skin.yaml colors #2089
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix part of #1951 by removing the hardcoded colours and setting them to the appropriate values from
skin.yml
file.The purpose was to remove places where colours were hardcoded. There are still forms of hardcoding the colours as these:
Style
structStyle
struct is not accessibleThe PR becomes quite large so I just wanted an opinion if it's meaningful or not continue replacing hardcoded colours even further.