Resources are rendered using skin.yaml colors #2089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placintaalexandru
force-pushed
the
Resources-are-rendered-using-skin.yaml-colors
branch
from
a0dbbc3
to
7483a68
Compare
placintaalexandru
force-pushed
the
Resources-are-rendered-using-skin.yaml-colors
branch
3 times, most recently
from
8d6cbc7
to
ddf1f4b
Compare
placintaalexandru
force-pushed
the
Resources-are-rendered-using-skin.yaml-colors
branch
from
ddf1f4b
to
57f9aae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix part of #1951 by removing the hardcoded colours and setting them to the appropriate values from
skin.ymlfile.The purpose was to remove places where colours were hardcoded. There are still forms of hardcoding the colours as these:
StylestructStylestruct is not accessibleThe PR becomes quite large so I just wanted an opinion if it's meaningful or not continue replacing hardcoded colours even further.