feat: add indicator to title if toast is toggled #2119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenicomastrangelo
approved these changes
Jun 8, 2023
derailed
reviewed
Jun 14, 2023
There was a problem hiding this comment.
@kopecmaciej Thank you for this PR Maciej! I think we should perhaps be more generic given that icons might not be viable in some terminal/distros and give user an option to display text as an alternate. So perhaps something like toastIndicator might be more generic. Also might be better to append to the title is Pod! or Pod Faults or Pod ☠️ might make more sense?
kopecmaciej
changed the title
|
Hey @derailed good idea, the indicator fits much better for this, + I changed the order, currently looks like this: |
|
Hi, @derailed, can this be merge or there is something that need to be fixed? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issues/2052
Hi. should this be turn off or on by default? Also do I need to update skins with
toastIcon? Thanks