Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour config for container picker #2140

Conversation

placintaalexandru
Copy link
Contributor

@placintaalexandru placintaalexandru commented Jun 19, 2023

#2139 and part of #1951

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@placintaalexandru Nice! Thank you Alexandru for your efforts to axe the canned colors

@placintaalexandru
Copy link
Contributor Author

placintaalexandru commented Aug 5, 2023

@derailed should I also update any documentation, if any, regarding the skins with the picker options?

@mklishevych
Copy link

Any way to move this forward? This PR is crucial to make k9s look decent in terminals with a light background. Without it looks like this.

image

@placintaalexandru
Copy link
Contributor Author

placintaalexandru commented Oct 23, 2023

Hello @mklishevych
@derailed is the only one I know with merge permissions. Meanwhile you can build this branch from source

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@placintaalexandru Sorry for the delay getting to this. Thanks you for these updates.
The issue I have with this is all the existing skins will need to be updated to ensure consistency. Hopefully the original owners will update??

@derailed derailed merged commit 5a8dc2d into derailed:master Nov 12, 2023
rm-hull added a commit to rm-hull/k9s that referenced this pull request Nov 12, 2023
* 'master' of github.com:derailed/k9s: (130 commits)
  added flux suspended resources retrieval plugin (derailed#1584)
  Provide white blur so images work in dark modes (derailed#1597)
  Add context to get-all (derailed#1701)
  fix brew command in the readme (derailed#2012)
  Add support for using custom kubeconfig with log_full plugin (derailed#2014)
  feat: allow for multiple plugin files in $XDG_DATA_DIRS/k9s/plugins (derailed#2029)
  Clean up issues introduced by derailed#2125 (derailed#2289)
  Pod view resembles more the output of kubectl get pods -o wide (derailed#2125)
  Update README.md with snap install (derailed#2262)
  Add snapcraft config (derailed#2123)
  storageclasses view keeps the same output as kubectl get sc (derailed#2132)
  Fix merge issues with PR derailed#2168 (derailed#2288)
  Add colour config for container picker (derailed#2140)
  Add env var to disable node pod counts (derailed#2168)
  Use current k9s NS if new context has no default NS (derailed#2197)
  Bump actions/setup-go from 4.0.1 to 4.1.0 (derailed#2200)
  fix: trigger a single log refresh after changing 'since' (derailed#2202)
  Add crossplane plugin (derailed#2204)
  fix(derailed#1359): add option to keep missing clusters in config (derailed#2213)
  K9s release v0.28.2
  ...
@placintaalexandru placintaalexandru deleted the Add-colour-config-for-container-picker branch November 13, 2023 08:00
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
placintaalexandru added a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants