Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply keyConv to mnemonic in menus #2161

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

thatsmydoing
Copy link
Contributor

This fixes an issue where namespaces with "alt" in the name get replaced by "opt" when running on macOS.

This fixes an issue where namespaces with "alt" in the name get replaced
by "opt" when running on macOS.
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thatsmydoing Great catch Thomas! Thank you!

@derailed derailed merged commit 55c1905 into derailed:master Jul 26, 2023
@thatsmydoing thatsmydoing deleted the fix-opt branch July 26, 2023 19:26
@derailed derailed mentioned this pull request Nov 8, 2023
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
This fixes an issue where namespaces with "alt" in the name get replaced
by "opt" when running on macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants