Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading benchmark from the wrong directory #2272

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Nov 7, 2023

this PR fixes #2063.

By the way, should we distinguish between canceled and failed benchmark?

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Awesome! Thank you for this update Jayson!
My take if the benchmark times out or error out we should not treat them differently as they should be both considered failures.

@derailed derailed merged commit 68afb3d into derailed:master Nov 8, 2023
3 checks passed
@wjiec wjiec deleted the bugfix/benchmark branch November 9, 2023 01:24
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Benchmark File not Accessible
2 participants