Add leading space to Kubernetes context suggestions #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Tested the PR and its working as expected. @derailed I think this can be merged with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the current behavior of
ctxsuggestions. Previously, when users typedctx, the first context suggestion would appear immediately adjacent toctxwithout a leading space (e.g.,ctx<context>), making it not possible to select the suggestion by pressing enter. This behavior required users to manually add a space before the context name, which was not intuitive and disrupted the workflow.The proposed change introduces a leading space to the context suggestions. Now, when
ctxis typed, the suggestion will appear asctx <context>, allowing users to seamlessly use the arrow keys to navigate through the context suggestions and select one by pressing enter. This enhancement streamlines the user experience by making context selection more intuitive and efficient.