Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HolmesGPT plugin #2822

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

pavangudiwada
Copy link
Contributor

This PR adds support for HolmesGPT an Open source DevOps assistant that helps with investigating issues in a cluster.

There are two modes, to customize the investigation.

@KevinGimbel
Copy link

If I'm not mistaken the custom-holmesgpt action leaves the temp-ask.txt file laying around. Not sure where this file would be placed (current directory?) but it should be cleaned up. In my humble opinion the name temp-ask.txt is also too generic.

Maybe even better: Create a temporary file using mktemp:

$QUESTION_FILE=$(mktemp)
${EDITOR:-nano} $QUESTION_FILE

@pavangudiwada
Copy link
Contributor Author

@KevinGimbel You are absolutely right! I updated the custom-holmesgpt plugin. I'm not manually removing it because it's will be in the /tmp directory. Let me know if this works.

@KevinGimbel
Copy link

Looks better to me! Thanks 👍

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derailed derailed merged commit e7ddea6 into derailed:master Aug 15, 2024
2 of 3 checks passed
uozalp pushed a commit to uozalp/k9s that referenced this pull request Sep 2, 2024
* Adding HolmesGPT plugin

* Updated to use a temporary file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants