Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate pod readiness gates when determining row color #2826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Evaluate pod readiness gates when determining row color #2826

wants to merge 1 commit into from

Conversation

jeremiahsnapp
Copy link

fixes #1760

derailed
derailed requested changes Aug 15, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremiahsnapp Thank you for this update!

internal/render/pod.go

idx, ok = h.IndexOf("READINESS GATES", true)
if ok {
rg := strings.TrimSpace(re.Row.Fields[idx])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to add this check in the diagnose section. This could confuse users as the pod will indicate issues and yet no explanation. What do you think?

@derailed derailed added enhancement New feature or request question Further information is requested labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed requested changes

Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colorize pod row if pod is not ready because of failing readiness gates
2 participants
@jeremiahsnapp @derailed