Ignore CLASSPATH if systemd is used #157
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deric Could you please take a look at this pull request and prepare a new release? |
|
Seems to be related to #104. Since you're up to this, can we clean up the environment file a bit? |
|
I think this is related to #147 and should be handled in a different pull request, which will only support distributions / releases with systemd. For example there is a lot of duplicate settings like USER, GROUP, PIDDIR or PIDFILE which are not necessary or already defined by the systemd unit file. |
|
Right, I agree. I'll try to fix failing tests before making a release. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-zookeeper
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fur further information take a look at: