A possible change in API to enable returning either box IDs or indices into array (or both)#4
Open
alexpyattaev wants to merge 9 commits intoderivator:mainfrom
Open
A possible change in API to enable returning either box IDs or indices into array (or both)#4alexpyattaev wants to merge 9 commits intoderivator:mainfrom
alexpyattaev wants to merge 9 commits intoderivator:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! We love the library but found it necessary to have it return indices into box array (as we do not want to use a hashmap to convert from box IDs back into box's coordinates). As a result we've made this special return enum that allows the caller to fetch either IDs or box indices in the set (or both), as appropriate. It compiles into the same assembly so it does not change the speed, just makes the API more flexible. Let me know if this is interesting/useful.