Open
Conversation
Owner
|
Sounds good, I want to test it first, but I will probably merge this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now egui_vulkano does not use correct blending for premultiplied alpha causing weird glitches, eg in my application windows shadow when rendered on top of the game, cause the alpha of frame buffer to drop and game window becomes transparent around egui windows. That's because alpha channel is blended incorrectly, it should use (ONE, ONE_MINUS_SRC_ALPHA) for both color and alpha, right now it is (SRC_ALPHA, ONE_MINUS_SRC_ALPHA), so the source alpha gets squared and does not add up to 1 when drawing a transparent element over opaque destination.
This PR fixes it.