Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 3.x Version of Addon #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Godot 3.x Version of Addon #4

wants to merge 2 commits into from

Conversation

hamoom
Copy link

@hamoom hamoom commented Apr 27, 2024

I want to have this merged into a 3.x branch in your project. This is just the same code converted into an older gdscript for godot 3.x projects.

@derkork
Copy link
Owner

derkork commented May 1, 2024

Thank you very much for taking the time to write this! I can merge it into a 3.x branch but I have no bandwidth available to maintain and support two versions of this plugin. This means I will not be able to do the following:

  • provide support for this branch (e.g. process issues).
  • create releases from this branch.
  • publish this branch on the asset library.
  • backport bugfixes or improvements to this branch.
  • update the documentation to match the changed interface in this branch.

So I see two ways forward from here:

  1. I merge this, add a remark that an unsupported 3.x version is available but people will have to download it through the GitHub interface and install it manually. I'll also add a remark that this is completely unsupported.
  2. I don't merge this and you maintain the 3.x version of this yourself (with everything that this entails, e.g. support it, update maybe push it to the asset library). In this case I'd just add a remark to my docs that there is a 3.x version available over at your repo and people can download it from there.

I know neither of these options is really ideal. Again, I really appreciate you took the time to make it and I know this may be frustrating to you. But at the end of the day I have to work with the bandwidth available to me.

@hamoom
Copy link
Author

hamoom commented May 2, 2024

Hey no problem. It's up to you. I'm surprised you need to spend time maintaining this though. It seems like a relatively simple plugin and the code is 90% identical between versions. Also the 3.x version is only getting one more update to 3.6 which I doubt would break any of the code here. I don't really believe you'd need to maintain a 3.x version as no more changes are happening to godot 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants