Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add GitHub Actions workflow to test builds #121

Merged
merged 8 commits into from
May 17, 2024
Merged

chore: add GitHub Actions workflow to test builds #121

merged 8 commits into from
May 17, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented May 16, 2024 •
edited
Loading

Summary

  1. Use default Github Node.js action to validate build

Closes #34

@KevinWu098 KevinWu098 requested review from ryqndev and a team May 16, 2024 21:56
taesungh
taesungh reviewed May 16, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, I meant to add a long time ago as part of #34 but never had the chance. Some small suggestions on naming and versions.

.github/workflows/node.js.yml Outdated Show resolved Hide resolved
.github/workflows/node.js.yml Outdated Show resolved Hide resolved
.github/workflows/node.js.yml Outdated Show resolved Hide resolved
@KevinWu098 KevinWu098 requested a review from taesungh May 16, 2024 23:02
@KevinWu098
Copy link
Member Author

Thanks for the feedback @taesungh ! I've linked #34 to this PR and added in linting as an additional check

@KevinWu098 KevinWu098 requested a review from taesungh May 16, 2024 23:28
@taesungh taesungh changed the title chore: add Github action to test builds chore: add GitHub Actions workflow to test builds May 16, 2024
taesungh
taesungh approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting to add this, will hopefully help catch potential errors before merging. In the future, we can also look into more intricate actions which leave review comments. Please squash during merge.

@KevinWu098 KevinWu098 merged commit e4f055b into main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh approved these changes

@ryqndev ryqndev Awaiting requested review from ryqndev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add workflow to run checks on pull requests
2 participants
@KevinWu098 @taesungh