Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prettier, run format #129

Merged
merged 2 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
build
public/static
node_modules
*.yml
*node_modules*
*.yml
sanity-dauci/.sanity/*
sanity-dauci/dist/*
27 changes: 22 additions & 5 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,24 @@
{
"useTabs": true,
"tabWidth": 4,
"semi": true,
"singleQuote": false,
"printWidth": 80
"tabWidth": 4,
"useTabs": false,
Comment on lines -2 to +3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late, but want to argue that using tabs over spaces is more accessible for users who prefer different indentation sizes.

Copy link
Member Author

@KevinWu098 KevinWu098 Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's definitely my bad, I usually put tabs instead of spaces myself -- will fix

"printWidth": 80,
"plugins": ["@ianvs/prettier-plugin-sort-imports"],
"importOrder": [
"^(react/(.*)$)|^(react$)",
"^(next/(.*)$)|^(next$)",
"<THIRD_PARTY_MODULES>",
"",
"^types$",
"^~/types/(.*)$",
"^~/config/(.*)$",
"^~/lib/(.*)$",
"^~/hooks/(.*)$",
"^~/components/ui/(.*)$",
"^~/components/(.*)$",
"^~/styles/(.*)$",
"^~/app/(.*)$",
"",
"^[./]"
],
"importOrderParserPlugins": ["typescript", "jsx", "decorators-legacy"]
}
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ Currently, the final build size is about 50kb which isn't nearly big enough to w

### Immediate improvements to be made

- i18n?
- a11y - mouse hover interaction (fields - text, buttons - pointer), semantic html (text component for example should be switched to various h tags)
- pagination for events list
- A lot of styling still needs to be refactored
- i18n?
- a11y - mouse hover interaction (fields - text, buttons - pointer), semantic html (text component for example should be switched to various h tags)
- pagination for events list
- A lot of styling still needs to be refactored

### Later planned updates:

Expand Down
10 changes: 5 additions & 5 deletions jsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"compilerOptions": {
"jsx": "react",
"baseUrl": "src"
},
"include": ["src"]
"compilerOptions": {
"jsx": "react",
"baseUrl": "src"
},
"include": ["src"]
}
Loading