Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove content #134

Merged
merged 4 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ DUCI-website
│ ├── alumniBoard.json
│ ├── currentBoard.json
│ ├── merchList.json
│ ├── resources.json
│ ├── resources.ts
│ └── socials.json
├── .gitignore
├── package.json
Expand All @@ -62,7 +62,7 @@ DUCI-website
| alumniBoard.json | information of all alumni board members | `src/app/pages/About` |
| currentBoard.json | information of all current board members | `src/app/pages/About` |
| merchList.json | list of all historical merch data (currently only has stickers) | `src/app/pages/Merch` |
| resources.json | all design resources for club members | `src/app/pages/Resources`, `src/app/pages/ResourcesFeatured` |
| resources.ts | all design resources for club members | `src/app/pages/Resources`, `src/app/pages/ResourcesFeatured` |
| socials.json | social media links for DUCI | `src/app/pages/Contact`, `src/app/components/Nav`, `src/app/components/Footer` |
| short_socials.json | full social media icon-links for DUCI | `src/app/pages/Join`, `src/app/pages/Hey` |

Expand Down Expand Up @@ -117,14 +117,14 @@ An example is the list of board members that gets displayed in the `About` page.

### Suspense

Currently, the final build size is about 50kb which isn't nearly big enough to warrant implementing Suspense for every page but probably will have plans to do so since the infrastucture is there.
Currently, the final build size is about 50kb which isn't nearly big enough to warrant implementing Suspense for every page but probably will have plans to do so since the infrastructure is there.

### Immediate improvements to be made

- i18n?
- a11y - mouse hover interaction (fields - text, buttons - pointer), semantic html (text component for example should be switched to various h tags)
- pagination for events list
- A lot of styling still needs to be refactored
- i18n?
- a11y - mouse hover interaction (fields - text, buttons - pointer), semantic html (text component for example should be switched to various h tags)
- pagination for events list
- A lot of styling still needs to be refactored

### Later planned updates:

Expand Down
3 changes: 1 addition & 2 deletions src/app/App.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Route, Routes, Navigate } from "react-router-dom";

import { Banner, Footer, Nav } from "./components";
import { Footer, Nav } from "./components";
import { useScroll } from "./controllers";
import {
About,
Expand Down Expand Up @@ -38,7 +38,6 @@ function App() {

return (
<>
<Banner />
<Nav />
<Routes>
<Route path="/" element={<Home />} />
Expand Down
19 changes: 3 additions & 16 deletions src/app/components/Footer/Footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ const Footer = () => (
src={icons.default}
style={{ marginRight: "16px" }}
/>
<Text style={{ textTransform: "capitalize" }}>{name}</Text>
<Text style={{ textTransform: "capitalize" }}>
{name}
</Text>
</a>
</div>
))}
Expand All @@ -51,26 +53,11 @@ const Footer = () => (
<Text>Project Teams</Text>
</Link>
</div>
<div>
<Link to="/mentorship">
<Text>Mentorship</Text>
</Link>
</div>
<div>
<Link to="/merch/">
<Text>Merch</Text>
</Link>
</div>
<div>
<Link to="/designathons/">
<Text>Design-a-thon</Text>
</Link>
</div>
<div>
<a target="noreferer" href="https://medium.com/@designatuci">
<Text>Board Blogs</Text>
</a>
</div>
<div>
<a
target="noreferer"
Expand Down
2 changes: 1 addition & 1 deletion src/app/pages/Resources/Resources.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Link } from "react-router-dom";

import { Text } from "app/components";
import { Section, Icon, Space } from "app/Symbols.js";
import RESOURCES from "assets/data/resources.json";
import { RESOURCES } from "assets/data/resources.ts";

import cn from "./Resources.module.scss";

Expand Down
77 changes: 0 additions & 77 deletions src/assets/data/resources.json

This file was deleted.

60 changes: 60 additions & 0 deletions src/assets/data/resources.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
type Resource = {
title: string;
link: string;
desc: string;
newTab?: boolean;
main: string;
accent: string;
background: string;
icon: string;
};

export const RESOURCES: Resource[] = [
{
title: "Project Teams",
link: "/project-teams",
desc: "Work on a team to design a beautiful large-scale product.",
main: "red",
accent: "gray",
background: "var(--blush)",
icon: "res-pt.svg",
},
{
title: "Workshop Slides",
link: "https://drive.google.com/drive/folders/14yhiCBnk0E6GECv8LPwSxduM1Nb6GOAQ?usp=sharing",
desc: "View past workshop slides.",
newTab: true,
main: "orange",
accent: "gray",
background: "#ffe4d4",
icon: "res-slides.svg",
},
{
title: "Featured Resources",
link: "/resources/featured/",
desc: "Explore our curated collection of useful online tools, guides, and more.",
main: "orange",
accent: "gray",
background: "var(--peach)",
icon: "res-featured.svg",
},
{
title: "Design-a-thon",
link: "/designathons/",
desc: "Our biggest event held every year. Teams design and compete for prizes",
main: "blue",
accent: "gray",
background: "var(--sky)",
icon: "res-designathon.svg",
},
{
title: "Newsletter Archive",
link: "https://us16.campaign-archive.com/home/?u=96e1277e37e6f4c2940cd1dc9&id=3cdf6c3ea8",
desc: "View past newsletters.",
newTab: true,
main: "black",
accent: "gray",
background: "var(--silver)",
icon: "res-archive.svg",
},
];