Repository navigation
Conversation
…rations css(a, b) composing classes whose styles the build knows, bound to css() in the file or exported by another module, merges their atoms per property, selector, breakpoint and layer, conditions included, instead of joining classes whose winner the stylesheet order picked. vanilla-extract style([...]) passes each composed style as its own argument, keeping a style composed again later. Refs #688 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #688 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #688 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #688 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…asurable Refs #688 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…JSX spreads win Refs #688 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…led order and JSX element className Refs #688 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #689 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…uate shouldForwardProp at build time Refs #689 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…ring Refs #689 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…APIs Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…t/react-18-fixture
…t/react-18-fixture
Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…rate the benchmark tables from one result Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…s against Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…ize budget Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…e first CI run of the new policy Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Resolve .github/workflows/publish.yml by retaining both React 18 and main vinext/RSC CSS acceptance jobs as independent siblings. Keep every main job and step byte-equivalent after YAML parsing, preserve #700 published versions with React peer/dev dependency intent, and regenerate lockfile workspace metadata through bun install. Refs #691, #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Merge #731 head 5644a8a containing main a935315. Resolve .github/workflows/publish.yml by keeping the complete main vinext job and publish validation comment, extending every action SHA/toolchain/cache pin plus timeout30/read-only permissions to vinext. Keep React18 and both CSS modes, original release/deploy needs, #700 published versions and the clean-pkg build script. Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Merge #744 head 7a81003 containing main a935315. No new manual conflict files: .github/workflows/publish.yml cleanly inherits the hardened vinext/React18 job union and read-only validation with action SHA pins/timeouts. Preserve the calibrated benchmark manifest/baseline/results, regression rules, SemanticBuilder bench and WASM budgets byte-for-byte, plus all main published versions and acceptance steps. Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #683 (W25: INF-21, PLG-26, INF-03, INF-02, INF-05). #746 위에 쌓은 변경이며 기반은
1936fa36입니다. #744와 #746이 먼저 병합되어야 합니다.요약
resetStateForTesting()을 추가하고 sheet, resolver, 설정, 네 map, 사용자 shorthand, 반응형 theme registry 및 imported stylesheet cache를 함께 초기화합니다.동작
정적 layout/spacing/color, imported styling module, 반응형 규칙, hover, extends theme, 동적 CSS variable을 확인합니다. 같은 길이의 style/theme 편집 및 prop 제거 후 production 재빌드도 확인하며 dev HMR 전체 coverage라고 주장하지 않습니다. Vite의 잘못된 runtime style 입력은 실제 build가 위치 있는 오류로 거부해야 합니다.
빌드와 브라우저는 순차 실행하며 전체 command process tree의 private memory를 1초마다 측정합니다. 6 GiB 또는 10분을 넘으면 process tree를 중단하고 finding으로 기록합니다. 서버는 임시 port를 사용하고 finally에서 닫습니다. CI에는 versioned Cargo/Bun/browser cache와 30분 timeout, JSON 증거 artifact를 추가합니다.
새로 생기는 오류
애플리케이션의 새 build error는 없습니다. 기존
styles.mjs:1:61: css() cannot use window.name at build time오류가 production 경로에서도 발생함을 검증합니다. watchdog 중단은 테스트 finding이며 compiler fallback이나 styling runtime을 추가하지 않습니다.남는 한계
rgb(19, 87, 155), 실제 검정. #755의 공유 CSS/plugin 작업과 함께 해결·재검증해야 하며 우회나 expected failure를 추가하지 않았습니다.rgb(23, 57, 91), 실제 검정. 실제 emitted CSS에는 선언을 사용하는 규칙은 있으나 theme 변수 선언이 없음을 확인했습니다. 코디네이터에게 전달했으며 fix(plugin-core): align bundler resolution, roots and WASM diagnostics #755/#752에 이미 수정됐다고 주장하지 않습니다.optimization.minimize:false를 명시하며 독립 설치/다른 Webpack 버전 또는 minifier 호환성 검증이라고 주장하지 않습니다.검증
cargo fmt --all, Rust 1.99 workspace all-target clippy: 통과.cargo test --workspace: 2,179 통과, 실패 0, 새 snapshot 없음.f01f04cb75b8c2835f2442d5ad6d0a303a5db3e6. 실제 production QA 다섯 행이 실패하므로 draft이며 release-compatible/merge-ready를 주장하지 않습니다.CI
첫 run
37657655987은 기존 publish·benchmark·landing-next-e2e·vinext-rsc-css-e2e·react-18 모두 SUCCESS입니다. publish는 Linux Rust 100%(10,569/10,569), Bun 5,516/0·100%, preload 회귀, landing 양 mode 및 Codecov/clean checkout/changepack까지 통과했습니다.새 release job만 compiler process 종료와
/proc/smaps_rollupread 사이의 ESRCH race로 package build에서 실패했습니다. 첫 run이 fixture 다섯 style 실패까지 실행됐다고 주장하지 않습니다.f01f04cb에서 종료된 process의 ENOENT/ESRCH만 0으로 처리하고 live process의 permission error는 그대로 실패시키며 6 GiB cap을 유지합니다. 회귀는 이전 동작에서 3/4(ESRCH 실패), 수정 후 4/4로 검증했고 package-build JSON 증거도 초기 실패부터 업로드합니다. 실제 local guarded package build는 72.85초/1,924,718,592 private bytes/exit0입니다.최종 head
f01f04cb의 run37664589766은 FAILURE이며 기존 다섯 job은 다시 전부 SUCCESS입니다. publish는 Rust 100%(10,569/10,569), Bun 5,516/0·100%, preload·양 landing mode·Codecov·clean checkout·changepack을 통과했습니다. 새release-compatjob은 sampler 4/4, guarded package build 157.48초/1,911,885,824 bytes/exit0, browser 설치 및 증거 업로드까지 성공했으며 실제 consumer 단계에서 앞서 보고한 style 실패 다섯 개만 재현했습니다. 다섯 assertion을 skip/expected failure로 바꾸거나 plugin 내부를 수정하지 않습니다.CI의 consumer matrix는 49 command/104.01초/최대 private 1,315,094,528 bytes, job 전체 6분13초로 30분 timeout 이내였습니다. watchdog memory stop이나 남은 server/browser는 없었습니다. 업로드된
release-package-build.json과release-results.json에서 finding·실제 command output·시간·memory를 확인할 수 있습니다. #755의 shared CSS/plugin 수정 및 관련 #752 통합 이후 이 동일 fixture를 다시 green으로 검증해야 하므로 merge-ready가 아닙니다.