Skip to content

Conversation

@y-cg
Copy link

@y-cg y-cg commented Jan 7, 2026

It seems that ticktick maintains two different endpoints:

  • ticktick.com for oversea users
  • dida365 for chinese users

This PR allow user to override the endpoint via TICKTICK_DOMAIN env var. I have manually tested that apis are identical for two hosts.

@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@y-cg
Copy link
Author

y-cg commented Jan 7, 2026

The implementation is a little bit "hacky". I try to put the domain config to TickTickSettings, but confused by the constant module. I notice that some implementations get url point from APIVersion and some get url endpoint from TICKTICK_API_BASE_* constant. It seems that all the ways I can think of would break backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant