frontend task #4 @theo4u #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clux2605 you did the SVG logo yourself? |
frontend/category.html
Outdated
| <body> | ||
| <div id="logo"> | ||
| <a href="index.html"> | ||
| <img src="res/devcenter-logo.svg"> |
There was a problem hiding this comment.
not found, no res folder instead assets/img/
There was a problem hiding this comment.
oh, my bad, forgot to change the dir when i changed the folder structure.
frontend/explainer.html
Outdated
| <h4>We then use that to create a track that might be the most engaging way for you to get into tech.</h4> | ||
| </div> | ||
| <div id="button"> | ||
| <button type="button" href="category.html">Begin</button> |
There was a problem hiding this comment.
this should be a link, <a href="category.html">Begin</a>
frontend/index.html
Outdated
| <h3>We understand that coding can be a bit confusing at the beginning and we are here to help you get started.</h3> | ||
| </div> | ||
| <div id="button"> | ||
| <button type="button" href="explainer.html">How?</button> |
There was a problem hiding this comment.
same as above, use link
frontend/index.html
Outdated
| <body> | ||
| <div id="logo"> | ||
| <a href="./"> | ||
| <img src="res/devcenter-logo.svg"> |
frontend/question.html
Outdated
| <hr> | ||
|
|
||
| <div> | ||
| <input type="checkbox" name="question-1-answers" id="question-1-answers-A" value="A" /> |
There was a problem hiding this comment.
the checkbox should be radio button as you can only pick one answer per question
|
check the comments placed on changed files, and no result page #4 last image |
theoomoregbee
requested changes
Aug 18, 2017
theoomoregbee
requested changes
Aug 19, 2017
frontend/index.html
Outdated
| <div id="content"> | ||
| <h2>Coding101 aims to help people who are interested in coding get an head start.</h2> | ||
| <div id="logo"> | ||
| <a href="./"> |
There was a problem hiding this comment.
no need for thr link here, anyway href should be # instead
frontend/index.html
Outdated
| <h3>We understand that coding can be a bit confusing at the beginning and we are here to help you get started.</h3> | ||
| </div> | ||
| <div id="link"> | ||
| <a href="explainer.html"></a> |
frontend/explainer.html
Outdated
| <h4>We then use that to create a track that might be the most engaging way for you to get into tech.</h4> | ||
| </div> | ||
| <div id="link"> | ||
| <a href="category.html"></a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections to the folder structure