Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(#368): Rearranging Header #382

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AACHAL2303PATIL
Copy link

Description

This pull request addresses issue #368 by reorganizing the header and footer sections of our website.

Changes Made

  1. Header Update:

    • Removed the Contacts section from the header.
    • Replaced it with a new Companies section that links to the dedicated page.
  2. Footer Update:

    • Added the Contact section back into the footer for easy access.
  3. Company Page:

    • Created a dedicated page for the list of companies, sorted alphabetically.

Checklist

  • Confirmed that the Companies section appears in the header.
  • Ensured that the Contact information is accessible in the footer.
  • Verified that the company list is alphabetized and displays correctly.

Screenshot 2024-09-27 213148
Screenshot 2024-09-27 213211

Copy link
Contributor

@MandyMeindersma MandyMeindersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So when I check the preview I am seeing that the comanies page isn't actually loading?

But if I hard refresh it does load:

image

name: 'Contact',
icon: 'i-ph-phone-duotone',
to: '/contact',
name: 'Companies', // Changed from 'Contact' to 'Companies'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove these comments! Thank you :)

@AACHAL2303PATIL
Copy link
Author

I have made the necessary changes, and you can review them at your convenience.

@MandyMeindersma
Copy link
Contributor

hmmm I am still getting that error that the comanpies page isn't work right:
image

@MandyMeindersma
Copy link
Contributor

Also @AACHAL2303PATIL if you are going to do more open source contribution I would try to make your commits messages a little more descriptive rather than just the same message over and over again. It would help me review your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants