Skip to content

Fixed quite a bunch of issues with the old depot processing + more#75

Merged
devedse merged 1 commit intomasterfrom
RewriteOldDepotProcessingToNotStoreToDiskAnymore
Jun 16, 2025
Merged

Fixed quite a bunch of issues with the old depot processing + more#75
devedse merged 1 commit intomasterfrom
RewriteOldDepotProcessingToNotStoreToDiskAnymore

Conversation

@devedse
Copy link
Copy Markdown
Owner

@devedse devedse commented Jun 16, 2025

  • Don't store depots on disk anymore but rather just process them in memory
  • Fixed an issue where I would overwrite another setting to store the version. This caused 2 issues:
    • An issue where it redownloaded the depot file every hour
    • Issues when you enabled Feature_SkipLinesBasedOnBytesRead and disabled Feature_DirectSteamIntegration.

@devedse devedse requested a review from Copilot June 16, 2025 15:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors depot processing by shifting from disk-based handling to in-memory processing and fixes issues where settings were being overwritten. Key changes include:

  • Reformatting DbSetting initialization in SteamAppInfoService.
  • Refactoring SteamDepotEnricherHostedService to process depot files from an in-memory stream.
  • Updating SteamDepotDownloaderHostedService to remove disk file dependencies and adjust service registrations in Program.cs.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
DeveLanCacheUI_Backend/Services/SteamAppInfoService.cs Reformatted setting initialization for improved readability.
DeveLanCacheUI_Backend/Services/OriginalDepotEnricher/SteamDepotEnricherHostedService.cs Switched from file-based depot reading to in-memory stream processing and adjusted logging/statements.
DeveLanCacheUI_Backend/Services/OriginalDepotEnricher/SteamDepotDownloaderHostedService.cs Removed disk file handling logic, replaced file I/O with direct processing, and introduced error handling improvements.
DeveLanCacheUI_Backend/Program.cs Adjusted service registration for the depot enricher to support the new design.

@devedse devedse merged commit bd318f7 into master Jun 16, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants