Conversation
…'t download depots to file anymore.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors depot processing by shifting from disk-based handling to in-memory processing and fixes issues where settings were being overwritten. Key changes include:
- Reformatting DbSetting initialization in SteamAppInfoService.
- Refactoring SteamDepotEnricherHostedService to process depot files from an in-memory stream.
- Updating SteamDepotDownloaderHostedService to remove disk file dependencies and adjust service registrations in Program.cs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DeveLanCacheUI_Backend/Services/SteamAppInfoService.cs | Reformatted setting initialization for improved readability. |
| DeveLanCacheUI_Backend/Services/OriginalDepotEnricher/SteamDepotEnricherHostedService.cs | Switched from file-based depot reading to in-memory stream processing and adjusted logging/statements. |
| DeveLanCacheUI_Backend/Services/OriginalDepotEnricher/SteamDepotDownloaderHostedService.cs | Removed disk file handling logic, replaced file I/O with direct processing, and introduced error handling improvements. |
| DeveLanCacheUI_Backend/Program.cs | Adjusted service registration for the depot enricher to support the new design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature_SkipLinesBasedOnBytesReadand disabledFeature_DirectSteamIntegration.