Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Five issues fixed. #6

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pokemon/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@
from pokemon.models import Pokemon, PokemonTypes


# TODO: Add a serializer for PokemonTypes, and use it as a nested serializer for PokemonSerializer
class PokemonTypeSerializer(serializers.ModelSerializer):
class Meta:
model = PokemonTypes
fields = ('type', )


class PokemonSerializer(serializers.ModelSerializer):
types = PokemonTypeSerializer(many=True)

class Meta:
model = Pokemon
fields = ('id', 'name_english', 'name_japanese', 'name_chinese', 'name_french', 'hp', 'attack', 'defense',
'special_attack', 'special_defense', 'speed', )
'special_attack', 'special_defense', 'speed', 'types', )
44 changes: 36 additions & 8 deletions pokemon/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@ def pokemon_by_id(request, id):
"""
Get Pokemon by ID
"""
# TODO: Implement Endpoint
return HttpResponse(status=501)
try:
pokemon = Pokemon.objects.get(id=id)
serializer = PokemonSerializer(pokemon)
return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
except Pokemon.DoesNotExist:
return JsonResponse({'error': 'Not found'}, status=404)


@csrf_exempt
Expand All @@ -33,23 +37,47 @@ def pokemon_by_name(request, name):
"""
Get Pokemon by name
"""
# TODO: Implement Endpoint
return HttpResponse(status=501)
try:
pokemon = Pokemon.objects.get(name_english__iexact=name)
serializer = PokemonSerializer(pokemon)
return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
except Pokemon.DoesNotExist:
return JsonResponse({'error': 'Not found'}, status=404)


@csrf_exempt
def pokemon_by_type(request, pokemon_type):
"""
Get Pokemon by type
"""
# TODO: Implement Endpoint
return HttpResponse(status=501)
pokemon = Pokemon.objects.filter(types__type__iexact=pokemon_type)
if pokemon:
serializer = PokemonSerializer(pokemon, many=True)
return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
else:
return JsonResponse({'error': 'Bad request'}, status=400)


@csrf_exempt
def pokemon_by_hp(request):
"""
Get Pokemon by HP
"""
# TODO: Implement Endpoint
return HttpResponse(status=501)
pokemon = Pokemon.objects.all()
for k, v in request.GET.items():
if k == 'lt':
pokemon = pokemon.filter(hp__lt=v)
elif k == 'lte':
pokemon = pokemon.filter(hp__lte=v)
elif k == 'gt':
pokemon = pokemon.filter(hp__gt=v)
elif k == 'gte':
pokemon = pokemon.filter(hp__gte=v)
else:
return JsonResponse({'error': 'Invalid Operator. Must be one of ["gt","gte","lt","lte"]'},
status=400)
if pokemon:
serializer = PokemonSerializer(pokemon, many=True)
return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
else:
return JsonResponse({'error': 'Not found'}, status=404)